[gmlwls96] Week7 #913
Merged
[gmlwls96] Week7 #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obzva
approved these changes
Jan 23, 2025
| s.forEach { // s를 조회하면서 글자를 subStr에 담는다. | ||
| if (subStr.contains(it)) { // 단, 겹치는 글자가 있을경우 subStr의 len을 기록하고, 초기화 한다. | ||
| max = max(max, subStr.length) | ||
| subStr.delete(0, subStr.length) |
There was a problem hiding this comment.
이 로직이 오류를 유발합니다
답안 통과를 하지 못하고 있는데, 인지하고 계신가요?
| @@ -0,0 +1,43 @@ | |||
| class Solution { | |||
| // 시간 : O(N), 공간 O(N) | |||
There was a problem hiding this comment.
문제 설명에서 주어진 변수가 m, n (2차원 배열의 행, 열)이므로 복잡도 분석의 결과를 m, n을 이용해서 표현해주시거나 별도의 추가적인 설명을 곁들여주세요
| var answerRoot: ListNode? = null | ||
|
|
||
| while (currentHead != null) { | ||
| answerRoot = ListNode(currentHead.`val`).apply { next = answerRoot } |
There was a problem hiding this comment.
answerRoot 뒤에 새로운 ListNode 인스턴스를 생성해서 추가하고 있으니까 공간 복잡도가 O(1)이 아닐 것 같아요
Comment on lines
+3
to
+4
| // dp 알고리즘. pathMap[y][x]로 올수 있는 경로의 수는 | ||
| // 위쪽(pathMap[y - 1][x]) + 왼쪽( pathMap[y][x - 1]) 경로의 수의 합이다. |
There was a problem hiding this comment.
pathMap[y][x] = pathMap[y - 1][x]) + 왼쪽( pathMap[y][x - 1]
이 점화식을 잘 보면 공간복잡도를 1차원으로 줄일 수 있다는 걸 알 수 있습니다
한 번 최적화해보시는 걸 추천드립니다~!
|
@gmlwls96 longest-substring 문제는 틀린 답안을 수정하지도 않으셨는데 병합 진행하셨네요? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.